Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16145#discussion_r90936511
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ShuffledRowRDD.scala ---
@@ -117,7 +113,7 @@ class CoalescedPartitioner(val parent: Partitioner, val
partitionStartIndices: A
class ShuffledRowRDD(
var dependency: ShuffleDependency[Int, InternalRow, InternalRow],
specifiedPartitionStartIndices: Option[Array[Int]] = None)
- extends RDD[InternalRow](dependency.rdd.context, Nil) {
+ extends RDD[InternalRow](dependency.rdd.context, Seq(dependency)) {
--- End diff --
Agree, though it only has one other use at all:
```
private[spark] def markCheckpointed(): Unit = {
clearDependencies()
partitions_ = null
deps = null // Forget the constructor argument for dependencies too
}
```
Right now `ShuffledRowRDD` would always 'remember' its constructor
parameter separately, when this comment suggests that's not desirable. This
change would get rid of that. No idea if it makes any difference -- probably
doesn't either way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
