Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16131#discussion_r90986964
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
 ---
    @@ -505,7 +505,8 @@ object GeneralizedLinearRegression extends 
DefaultParamsReadable[GeneralizedLine
         override def initialize(y: Double, weight: Double): Double = {
           require(y >= 0.0, "The response variable of Poisson family " +
             s"should be non-negative, but got $y")
    -      y
    +      // Set lower bound for mean in the FIRST step in IWLS
    --- End diff --
    
    let's change this to `// force Poisson mean > 0 to avoid numerical 
instability in IRLS`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to