Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16160#discussion_r90990663
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/ForeachSinkSuite.scala
---
@@ -204,6 +204,55 @@ class ForeachSinkSuite extends StreamTest with
SharedSQLContext with BeforeAndAf
query.stop()
}
}
+
+ test("foreach with watermark: append") {
--- End diff --
actually complete mode should NOT work when watermark is enabled!! Why does
this query still work? Thats material for different PR. So I approve this
change in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
