Github user weiqingy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16159#discussion_r91006592
--- Diff: project/SparkBuild.scala ---
@@ -596,19 +596,17 @@ object Hive {
}
object Assembly {
- import sbtassembly.AssemblyUtils._
- import sbtassembly.Plugin._
- import AssemblyKeys._
+ import sbtassembly.AssemblyPlugin.autoImport._
val hadoopVersion = taskKey[String]("The version of hadoop that spark is
compiled against.")
- lazy val settings = assemblySettings ++ Seq(
+ lazy val settings = Seq(
--- End diff --
Hi, @srowen Thanks for reviewing this PR. Yes, removing `assemblySettings
++` is on purpose. [Quote from
[sbt-assembly/Migration.md](https://github.com/sbt/sbt-assembly/blob/master/Migration.md):
"Remove `assemblySettings.` The settings are now auto injected to all projects
with JvmPlugin" ]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]