Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16168#discussion_r91065717
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -114,9 +117,26 @@ private[hive] class HiveMetastoreCatalog(sparkSession:
SparkSession) extends Log
alias.map(a => SubqueryAlias(a, qualifiedTable,
None)).getOrElse(qualifiedTable)
} else if (table.tableType == CatalogTableType.VIEW) {
val viewText = table.viewText.getOrElse(sys.error("Invalid view
without text."))
+ val unresolvedPlan =
sparkSession.sessionState.sqlParser.parsePlan(viewText).transform {
+ case u: UnresolvedRelation if u.tableIdentifier.database.isEmpty =>
+ u.copy(tableIdentifier =
TableIdentifier(u.tableIdentifier.table, table.currentDatabase))
+ }
+ // Resolve the plan and check whether the analyzed plan is valid.
+ val resolvedPlan = try {
+ val resolvedPlan =
sparkSession.sessionState.analyzer.execute(unresolvedPlan)
+ sparkSession.sessionState.analyzer.checkAnalysis(resolvedPlan)
+
+ resolvedPlan
+ } catch {
+ case NonFatal(e) =>
+ throw new RuntimeException(s"Failed to analyze the canonicalized
SQL: $viewText", e)
+ }
+ val planWithProjection =
table.originalSchema.map(withProjection(resolvedPlan, _))
+ .getOrElse(resolvedPlan)
+
SubqueryAlias(
alias.getOrElse(table.identifier.table),
- sparkSession.sessionState.sqlParser.parsePlan(viewText),
+ aliasColumns(planWithProjection, table.schema.fields),
--- End diff --
Could we try to do one projection instead of two? And could we also avoid a
projection if we don't need it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
