GitHub user windpiger opened a pull request:
https://github.com/apache/spark/pull/16173
[SPARK-18742][CORE]readd spark.broadcast.factory conf to implement
er-defined BroadcastFactory
## What changes were proposed in this pull request?
After SPARK-12588 Remove HTTPBroadcast [1], the one and only
implementation of BroadcastFactory is TorrentBroadcastFactory. No code
in Spark 2 uses BroadcastFactory (but TorrentBroadcastFactory) however
the scaladoc says [2]:
/**
* An interface for all the broadcast implementations in Spark (to allow
* multiple broadcast implementations). SparkContext uses a user-specified
* BroadcastFactory implementation to instantiate a particular broadcast
for the
* entire Spark job.
*/
which is not correct since there is no way to plug in a custom
user-specified BroadcastFactory.
It is better to readd spark.broadcast.factory for user-defined
BroadcastFactory
[1] https://issues.apache.org/jira/browse/SPARK-12588
[2]
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/broadcast/BroadcastFactory.scala#L25-L30
## How was this patch tested?
unit test added
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/windpiger/spark addBroadFactoryConf
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16173.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16173
----
commit a17d3250d4472619fa987d9b389d48b165c44745
Author: root <root@izbp1gsnrlfzjxh82cz80vz.(none)>
Date: 2016-12-06T16:14:26Z
[SPARK-18742][CORE]readd spark.broadcast.factory conf to implement
user-defined BroadcastFactory
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
