Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/16154#discussion_r91136204
--- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala
---
@@ -143,12 +142,8 @@ private[r] class RBackendHandler(server: RBackend)
val cls = if (isStatic) {
Utils.classForName(objId)
} else {
- JVMObjectTracker.get(objId) match {
- case None => throw new IllegalArgumentException("Object not
found " + objId)
- case Some(o) =>
- obj = o
- o.getClass
- }
+ obj = server.jvmObjectTracker.get(JVMObjectId(objId))
--- End diff --
This is minor but the exception now thrown will be a `NullPointerException`
in place of what it was before ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
