Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16189#discussion_r91234634
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -229,9 +230,11 @@ private[spark] class Executor(
// ClosedByInterruptException during execBackend.statusUpdate which
causes
// Executor to crash
Thread.interrupted()
+ notifyAll()
}
override def run(): Unit = {
+ Thread.currentThread().setName(threadName)
--- End diff --
Task ids should be unique so therefore this thread name should be unique.
Hence, I don't think it's super important to reset the thread's name when
returning it to this task thread pool because the thread will just be renamed
as soon as it's recycled for a new task and if the task has already exited then
it'll be clear from the thread state / context that this is just a completed
task's thread that's been returned to the pool.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
