Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/14638#discussion_r91332545
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ---
@@ -122,10 +125,22 @@ class HadoopTableReader(
val attrsWithIndex = attributes.zipWithIndex
val mutableRow = new SpecificInternalRow(attributes.map(_.dataType))
- val deserializedHadoopRDD = hadoopRDD.mapPartitions { iter =>
+ val deserializedHadoopRDD = hadoopRDD.mapPartitionsWithIndex { (index,
iter) =>
val hconf = broadcastedHadoopConf.value.value
val deserializer = deserializerClass.newInstance()
deserializer.initialize(hconf, tableDesc.getProperties)
+ if (skipHeaderLineCount > 0 && isTextInputFormatTable) {
+ hadoopRDD.partitions(index) match {
+ case partition: HadoopPartition =>
+ if (partition.inputSplit.t.asInstanceOf[FileSplit].getStart()
== 0) {
+ var i = 0
+ while (i < skipHeaderLineCount && iter.hasNext) {
+ i += 1
+ iter.next()
+ }
+ }
--- End diff --
There is an assumption here that 'skipHeaderLineCount' lines will be in the
first split always ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
