Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/16195#discussion_r91375843 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala --- @@ -61,11 +61,12 @@ private[spark] class ClientArguments(args: Array[String], sparkConf: SparkConf) // Additional memory to allocate to containers val amMemoryOverheadConf = if (isClusterMode) driverMemOverheadKey else amMemOverheadKey - val amMemoryOverhead = sparkConf.getInt(amMemoryOverheadConf, - math.max((MEMORY_OVERHEAD_FACTOR * amMemory).toInt, MEMORY_OVERHEAD_MIN)) - - val executorMemoryOverhead = sparkConf.getInt("spark.yarn.executor.memoryOverhead", - math.max((MEMORY_OVERHEAD_FACTOR * executorMemory).toInt, MEMORY_OVERHEAD_MIN)) + val amMemoryOverhead = sparkConf + .getSizeAsMb(amMemoryOverheadConf, + math.max((MEMORY_OVERHEAD_FACTOR * executorMemory).toInt, MEMORY_OVERHEAD_MIN).toString).toInt --- End diff -- Indentation here is really weird. I recommend instead: ``` val amMemoryOverhead = sparkConf.getSizeAsMb( amMemoryOverheadConf, blah blah blah) ``` Same elsewhere. Might be even good to pull the default value calculation into a separate variable.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org