Github user velvia commented on the issue:
https://github.com/apache/spark/pull/15219
@kiszk I had a quick look at your `ColumnarVector` and had some thoughts.
Right now, it seems `ColumnVector` as an abstract class mixes lots of
functionalities into one.
- Methods for reading primitive and other values from a "column"
- Methods for appending and modifying a column, modifying nullity etc.
I would strongly recommend separating into at least two different
interfaces (or Scala traits):
- a `ReadableColumnVector` trait that is read-only
- a `MutableColumnVector` trait which includes write or append methods
For my use case, for example, caching and creating the column vector is not
needed, instead I would like to implement the ReadableColumnVector API for
reading columnar chunks which I supply. (eg for example, there would be an
ApacheArrowReadableColumnVector).
This would simplify the interface and make it easier to integrate. Thanks
and good work!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
