GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/16230
[SPARK-13747][Core]Fix potential ThreadLocal leaks in RPC when using
ForkJoinPool
## What changes were proposed in this pull request?
Some places in SQL may call `RpcEndpointRef.askWithRetry` (e.g.,
ParquetFileFormat.buildReader -> SparkContext.broadcast -> ... ->
BlockManagerMaster.updateBlockInfo -> RpcEndpointRef.askWithRetry), which will
finally call `Await.result`. It may cause `java.lang.IllegalArgumentException:
spark.sql.execution.id is already set` when running in Scala ForkJoinPool.
This PR includes the following changes to fix this issue:
- Removed `ThreadUtils.awaitResult`
- Renamed `ThreadUtils. awaitResultInForkJoinSafely` to
`ThreadUtils.awaitResult`
- Replaced `Await.result` in RpcTimeout with `ThreadUtils.awaitResult`.
## How was this patch tested?
Jenkins
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zsxwing/spark fix-SPARK-13747
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16230.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16230
----
commit 68ae0ed3266787944952c01bdd4f1eb7cbfc42a0
Author: Shixiong Zhu <[email protected]>
Date: 2016-12-09T07:22:46Z
Fix potential ThreadLocal leaks when using ForkJoinPool
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
