Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/16175#discussion_r91765482
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -115,7 +115,8 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
*/
private def canBroadcast(plan: LogicalPlan): Boolean = {
plan.statistics.isBroadcastable ||
- plan.statistics.sizeInBytes <= conf.autoBroadcastJoinThreshold
+ (plan.statistics.sizeInBytes >= 0 &&
--- End diff --
@cloud-fan @gatorsmile
Thank you all for your comments. I will change defaultSizeInBytes based on
the above comments.
Seems all the other places of Statistics.sizeInBytes are safe and will not
cause overflow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
