Github user brkyvz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16114#discussion_r91774523
  
    --- Diff: 
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
 ---
    @@ -221,6 +221,12 @@ private[kinesis] class KinesisReceiver[T](
         }
       }
     
    +  /** Return the current rate limit defined in [[BlockGenerator]]. */
    +  private[kinesis] def getCurrentLimit: Int = {
    +    assert(blockGenerator != null)
    --- End diff --
    
    I would be okay to keep it if we add a useful error in case this assertion 
doesn't hold, e.g.
    `assert(blockGenerator != null, "Expected blockGenerator to be set for the 
receiver before the processor received records")`
    
    or something like that


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to