Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16246#discussion_r91840263
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1230,10 +1230,24 @@ class Analyzer(
*/
private def rewriteSubQuery(
sub: LogicalPlan,
- outer: Seq[LogicalPlan]): (LogicalPlan, Seq[Expression]) = {
+ outer: Seq[LogicalPlan],
+ scalarSubq: Boolean = false): (LogicalPlan, Seq[Expression]) = {
// Pull out the tagged predicates and rewrite the subquery in the
process.
val (basePlan, baseConditions) = pullOutCorrelatedPredicates(sub)
+ // SPARK-18504: block cases where GROUP BY columns
+ // are not part of the correlated columns
+ if (scalarSubq && sub.isInstanceOf[Aggregate]) {
+ val groupByCols = ExpressionSet.apply(sub.asInstanceOf[Aggregate].
--- End diff --
Nomally, when we need to do `isInstanceOf` and `asInstanceOf`, we use the
patten matching.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
