Github user lins05 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16189#discussion_r91855053
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -432,6 +458,78 @@ private[spark] class Executor(
}
/**
+ * Supervises the killing / cancellation of a task by sending the
interrupted flag, optionally
+ * sending a Thread.interrupt(), and monitoring the task until it
finishes.
+ */
+ private class TaskReaper(
+ taskRunner: TaskRunner,
+ val interruptThread: Boolean)
+ extends Runnable {
+
+ private[this] val taskId: Long = taskRunner.taskId
+
+ private[this] val killPollingFrequencyMs: Long =
+ conf.getTimeAsMs("spark.task.killPollingFrequency", "10s")
+
+ private[this] val killTimeoutMs: Long =
conf.getTimeAsMs("spark.task.killTimeout", "2m")
+
+ private[this] val takeThreadDump: Boolean =
+ conf.getBoolean("spark.task.threadDumpKilledTasks", true)
+
+ override def run(): Unit = {
+ val startTimeMs = System.currentTimeMillis()
+ def elapsedTimeMs = System.currentTimeMillis() - startTimeMs
+ try {
+ while (!taskRunner.isFinished && (elapsedTimeMs < killTimeoutMs ||
killTimeoutMs <= 0)) {
+ taskRunner.kill(interruptThread = interruptThread)
+ taskRunner.synchronized {
+ taskRunner.wait(killPollingFrequencyMs)
+ }
+ if (!taskRunner.isFinished) {
+ logWarning(s"Killed task $taskId is still running after
$elapsedTimeMs ms")
+ if (takeThreadDump) {
+ try {
+
Utils.getThreadDumpForThread(taskRunner.getThreadId).foreach { thread =>
+ if (thread.threadName == taskRunner.threadName) {
+ logWarning(s"Thread dump from task
$taskId:\n${thread.stackTrace}")
+ }
+ }
+ } catch {
+ case NonFatal(e) =>
+ logWarning("Exception thrown while obtaining thread
dump: ", e)
+ }
+ }
+ }
+ }
+
+ if (!taskRunner.isFinished && killTimeoutMs > 0 && elapsedTimeMs >
killTimeoutMs) {
--- End diff --
I see we also have `(elapsedTimeMs < killTimeoutMs || killTimeoutMs <= 0)`
above, what about extracting `killTimeoutMs > 0 && elapsedTimeMs >
killTimeoutMs` to a method, e.g `def timeoutExceeded(): Boolean`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
