Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16245#discussion_r91881557
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -514,6 +514,25 @@ case class OptimizeCodegen(conf: CatalystConf) extends
Rule[LogicalPlan] {
/**
+ * Reorders the predicates in `Filter` so more expensive expressions like
UDF can evaluate later.
+ */
+object ReorderPredicatesInFilter extends Rule[LogicalPlan] with
PredicateHelper {
+ def apply(plan: LogicalPlan): LogicalPlan = plan transform {
+ case Filter(pred, child) =>
+ // Reverses the expressions to get the suffix deterministic
expressions in the predicate.
+ // E.g., the original expressions are 'a > 1, rand(0), 'b > 2, 'c >
3.
+ // The reversed expressions are 'c > 3, 'b > 2, rand(0), 'a > 1.
+ // The suffix deterministic expressions are 'c > 3, 'b > 2.
+ val (deterministicExprs, others) =
splitConjunctivePredicates(pred).reverse
--- End diff --
how is the performance of this split, reverse, and span?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
