Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/16248#discussion_r91883327
--- Diff: R/pkg/R/utils.R ---
@@ -851,3 +851,12 @@ rbindRaws <- function(inputData){
out[!rawcolumns] <- lapply(out[!rawcolumns], unlist)
out
}
+
+# Get basename without extension from URL
+basenameSansExtFromUrl <- function(url) {
--- End diff --
can we use file_path_sans_ext [1] for removing the extension ? I worry we
might publish it as `.tar.gz` someday and then removing just the last `.` will
be insufficient
[1]
https://stat.ethz.ch/R-manual/R-patched/library/tools/html/fileutils.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
