Github user uncleGen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15915#discussion_r91888869
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala ---
@@ -78,6 +80,7 @@ private[spark] class TorrentBroadcast[T: ClassTag](obj:
T, id: Long)
}
// Note: use getSizeAsKb (not bytes) to maintain compatibility if no
units are provided
blockSize = conf.getSizeAsKb("spark.broadcast.blockSize", "4m").toInt
* 1024
+ chunkSize = SparkEnv.get.memoryManager.pageSizeBytes.toInt
checksumEnabled = conf.getBoolean("spark.broadcast.checksum", true)
--- End diff --
@JoshRosen We use `SparkEnv.get.memoryManager.pageSizeBytes` as chunk size.
As `SparkEnv.get.memoryManager.pageSizeBytes` returns `Long`, there is still
underlying integer overflow issue, isn't it? Besides, users will never know the
low level details and the effect to chunk size when modify `pageSizeBytes`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
