Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16145#discussion_r91938940
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ShuffledRowRDD.scala ---
@@ -132,7 +128,9 @@ class ShuffledRowRDD(
private[this] val part: Partitioner =
new CoalescedPartitioner(dependency.partitioner, partitionStartIndices)
- override def getDependencies: Seq[Dependency[_]] = List(dependency)
+ // Don't even think of removing the override
--- End diff --
Just don't change this section at all. I don't think this comment is
correct, even; it is actually probably OK to make the change you were thinking
of, just didn't seem worth verifying whether it would break something.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
