Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16250
I don't think these superficial changes meaningfully affect readability at
all, and I don't perceive that this is any significant barrier to anyone
modifying the code anyway. It's both an argument that to do it -- hey, why not
polish things a bit? -- and not do it -- not going to really help so why bother
at all.
There is a tiny risk of breaking something or regressing performance. There
is the very small problem of merge conflicts.
Mostly, it's a meta-issue: reviewer time. Remember it's not just me that
reads this, but a thousand people for at least a little bit of time. It
probably costs >$1000 of person-hours to get this change merged.
I think we're often happy to take trivial contributions from a new person
to encourage new participants, but, do look to more experienced folks to spend
time on reviews, fixing deeper issues, fixing broader issues.
We can keep saying this stuff and merging anyway but I have not seen
evidence that the message is getting across. This is why you may see at this
point we're asking you to not make changes like this and just close it.
None of these changes look essential even if I would have written it your
way in general, so I'd close this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
