Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/16252#discussion_r92231761
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -694,7 +694,7 @@ private[storage] class PartiallyUnrolledIterator[T](
}
override def next(): T = {
- if (unrolled == null) {
+ if (unrolled == null || !unrolled.hasNext) {
--- End diff --
You are right, next() without hasNext is a valid code flow, and our code
should not break due to caller not invoking hasNext (at best throw
NoSuchElementException if hasNext == false).
Another option is to add hasNext check here - but that would be worse
(since normal flow will then check hasNext twice).
If we cant ensure "require(unrolled == null || unrolled.hasNext)", then
current change is best we can do I guess.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
