Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2276#discussion_r17180863
  
    --- Diff: 
yarn/alpha/src/main/scala/org/apache/spark/deploy/yarn/YarnRMClientImpl.scala 
---
    @@ -96,7 +96,7 @@ private class YarnRMClientImpl(args: 
ApplicationMasterArguments) extends YarnRMC
         // Users can then monitor stderr/stdout on that node if required.
         appMasterRequest.setHost(Utils.localHostName())
         appMasterRequest.setRpcPort(0)
    -    appMasterRequest.setTrackingUrl(uiAddress)
    +    appMasterRequest.setTrackingUrl(uiAddress.replaceAll("^http(\\w)*://", 
""))
    --- End diff --
    
    I would rather this done with something more reliable like URI class and 
just removing the scheme if it has one.   
    
    Also can you add a comment about we are removing it because hadoop doesn't 
handle the scheme.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to