Github user vijoshi commented on a diff in the pull request:
https://github.com/apache/spark/pull/16119#discussion_r92333556
--- Diff: python/pyspark/sql/context.py ---
@@ -72,8 +72,13 @@ def __init__(self, sparkContext, sparkSession=None,
jsqlContext=None):
self._sc = sparkContext
self._jsc = self._sc._jsc
self._jvm = self._sc._jvm
+
if sparkSession is None:
- sparkSession = SparkSession(sparkContext)
+ if sparkContext is SparkContext._active_spark_context:
+ sparkSession = SparkSession.builder.getOrCreate()
--- End diff --
okay - I wanted to avoid adding code to the new SparkSession class to
handle this compatibility issue arising out of the now deprecated SQLContext
class. Looks like the python impl of SparkSession builder does not allow a
SparkContext to be passed in. Do we want to change the public builder interface
for this ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
