Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2227#discussion_r17184945
--- Diff:
core/src/test/scala/org/apache/spark/deploy/worker/WorkerArgumentsTest.scala ---
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+package org.apache.spark.deploy.worker
+
+import org.apache.spark.SparkConf
+import org.scalatest.FunSuite
+
+
+class WorkerArgumentsTest extends FunSuite {
+
+ test("Memory can't be set to 0 when cmd line args leave off M or G") {
+ val conf = new SparkConf
+ val args = Array("-m", "10000", "spark://localhost:0000 ")
+ intercept[IllegalStateException] {
+ new WorkerArguments(args, conf)
+ }
+ }
+
+
+/* For this test an environment property for SPARK_WORKER_MEMORY was set
--- End diff --
In #2002, I added a mechanism that allows environment variables to be
mocked in tests. Take a look at that PR, `SparkConf.getEnv` in particular. By
using a custom SparkConf subclass, you can mock environment variables on a
per-test basis:
https://github.com/apache/spark/pull/2002/files#diff-e9fb6be5f96766cce96c4d60aea2fc59R45
If we find ourselves doing this in multiple places (my PR, here, ...) it
might be nice to add some test helper classes for doing this more generically.
That refactoring can happen in a separate PR, though, so for now it's probably
fine to just copy my code snippet here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
