Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2287#discussion_r17188799
  
    --- Diff: python/pyspark/tests.py ---
    @@ -180,6 +180,22 @@ def tearDown(self):
             self.sc.stop()
             sys.path = self._old_sys_path
     
    +class CloudPickleTestCase(PySparkTestCase):
    +    def SetUp(self):
    +        PySparkTestCase.setUp(self)
    +    def tearDown(self):
    +        PySparkTestCase.tearDown(self)
    +    def test_CloudPickle(self):
    --- End diff --
    
    Also, `test_cloudpickle` isn't a very descriptive name; it will be hard for 
people that come along and read this later to figure out what this is supposed 
to be testing.  A better name would be `test_pickling_file_handles` (and maybe 
add a comment saying that it's a regression test for SPARK-3415).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to