Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16290#discussion_r92553387
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -2165,6 +2165,14 @@ test_that("SQL error message is returned from JVM", {
expect_equal(grepl("blah", retError), TRUE)
})
+test_that("Default warehouse dir should be set to tempdir", {
+ # nothing should be written outside tempdir() without explicit user
permission
+ inital_working_directory_files <- list.files()
--- End diff --
I'm referring to other tests in this test file, test_sparkSQL, that is
calling to API that might already initialize the warehouse dir.
`sparkR.session()` is called at the top. Does this
`createOrReplaceTempView` cause the warehouse dir to be created?
https://github.com/shivaram/spark-1/blob/25834109588e8e545deafb1da162958766a057e2/R/pkg/inst/tests/testthat/test_sparkSQL.R#L570
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
