Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15119#discussion_r92713539
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitUtilsSuite.scala ---
@@ -137,7 +139,9 @@ class SparkSubmitUtilsSuite extends SparkFunSuite with
BeforeAndAfterAll {
val dep = "my.great.dep:mydep:0.5"
// Local M2 repository
IvyTestUtils.withRepository(main, Some(dep),
Some(SparkSubmitUtils.m2Path)) { repo =>
- val jarPath =
SparkSubmitUtils.resolveMavenCoordinates(main.toString, None, None,
+ val jarPath = SparkSubmitUtils.resolveMavenCoordinates(
+ main.toString,
+ SparkSubmitUtils.buildIvySettings(None, None),
--- End diff --
It would be nice to add a test that creates a settings file and uses it,
instead of calling this method on every test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
