Github user ZakariaHili commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16295#discussion_r92782402
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala 
---
    @@ -302,22 +302,19 @@ class KMeans @Since("1.5.0") (
     
       @Since("2.0.0")
       override def fit(dataset: Dataset[_]): KMeansModel = {
    -    val handlePersistence = dataset.rdd.getStorageLevel == 
StorageLevel.NONE
    -    fit(dataset, handlePersistence)
    -  }
    -
    -  @Since("2.2.0")
    -  protected def fit(dataset: Dataset[_], handlePersistence: Boolean): 
KMeansModel = {
    --- End diff --
    
    @hhbyyh, so that means that we should do the same things for others methods:
    caching rdd before training for for:
    -GaussianMixture.scala
    -BisectingKMeans.scala
    -LDA.scala
    and remove the extrat train() method for all methods in the package 
classification.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to