Github user ericl commented on the issue:
https://github.com/apache/spark/pull/15983
It's the hive behavior to not repair the table. Otherwise, create table can
have an unbounded cost if there are many partitions.
On Sat, Dec 17, 2016, 5:12 PM Xiao Li <[email protected]> wrote:
> *@gatorsmile* commented on this pull request.
> ------------------------------
>
> In
>
sql/hive/src/test/scala/org/apache/spark/sql/hive/PartitionProviderCompatibilitySuite.scala
> <https://github.com/apache/spark/pull/15983#pullrequestreview-13455778>:
>
> > @@ -188,6 +188,25 @@ class PartitionProviderCompatibilitySuite
> }
> }
>
> + for (enabled <- Seq(true, false)) {
> + test(s"SPARK-18544 append with saveAsTable - partition management
$enabled") {
> + withSQLConf(SQLConf.HIVE_MANAGE_FILESOURCE_PARTITIONS.key ->
enabled.toString) {
> + withTable("test") {
> + withTempDir { dir =>
> + setupPartitionedDatasourceTable("test", dir)
> + if (enabled) {
> + spark.sql("msck repair table test")
>
> If HIVE_MANAGE_FILESOURCE_PARTITIONS is on, we have to repair the table;
> otherwise the table is empty to the external users. This looks weird to
me.
> It is also inconsistent with the behavior when
> HIVE_MANAGE_FILESOURCE_PARTITIONS is off. I think we should repair the
> table after we create the table. Let me submit a PR and cc you then.
>
> â
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/spark/pull/15983#pullrequestreview-13455778>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AAA6Sq9Ee_qTVz9aI85PcIu2z0MEoJKDks5rJIhrgaJpZM4K6Hh0>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
