Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/16328
  
    I finished this approach for completeness, but I see that it requires 
'fixing' `StreamingKMeansModel` to return a new model instead of strictly 
updating its vectors in place. It's not actually a big deal but would cause a 
problem if anyone called `StreamingKMeansModel.update` without using its return 
value. Spark doesn't and I'm not sure if it's valid. 
    
    There's another way to approach this by passing around a broadcast 
variable. It's narrower and a bit more complex, so it'd be nice if we could 
make this change, but it's not the only solution. Leaving it open for comments, 
esp. from Jenkins.
    
    CC @freeman-lab and @mengxr 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to