Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16335#discussion_r92992596
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLogSuite.scala
---
@@ -209,14 +209,20 @@ class HDFSMetadataLogSuite extends SparkFunSuite with
SharedSQLContext {
}
// Open and delete
- val f1 = fm.open(path)
- fm.delete(path)
- assert(!fm.exists(path))
- intercept[IOException] {
- fm.open(path)
+ if (Utils.isWindows) {
+ fm.open(path).close()
+ fm.delete(path)
+ fm.delete(path) // should not throw exception
--- End diff --
Why does windows need two deletes? It seems funny we'd need an entirely
different path to delete the file just here and just on Windows?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
