Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16337
@nsyca @kevinyu98
### 1. Correctness
> how about running the same set of test cases against a second SQL system
and comparing the results?
Yeah, that works. I am just trying to make sure that nothing slips through
the cracks here.
### 2. Size
The PR is huge and that makes it relatively hard to review (without missing
things). Testing against another DB would help a lot for reviewing purposes (it
would effectively m).
### 3. Test kit
I was impressed by the completeness of the tests. I was just wondering if
you have wrote them (kudos), or if they are a part of an existing test frame
work.
### 4. Negative testing
We might have to clean-up (remove expr_ids) from the LogicalPlan a little
bit to make negative testing work. An Analysis Exception should contain the
failing plan, and we could use code similar to
https://github.com/apache/spark/blob/master/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/PlanTest.scala#L30-L74
to get this working.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
