Github user kayousterhout commented on the issue:

    https://github.com/apache/spark/pull/12775
  
    @mridulm what's the scenario you're imagining where it's worse to catch the 
exception?  I'm imagining one of two scenarios:
    
    (1) There's a recoverable exception, in which case we should properly 
register the task as failed (otherwise the job will hang) and log the exception 
(which is what this PR does).
    
    (2) There's an irrecoverable exception.  My understanding is that this 
change only impacts the logging in that case (since the relevant thread is 
going to die anyway).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to