GitHub user imatiach-msft opened a pull request:

    https://github.com/apache/spark/pull/16355

    [SPARK-16473][MLLIB] Fix BisectingKMeans Algorithm failing in edge case

    [SPARK-16473][MLLIB] Fix BisectingKMeans Algorithm failing in edge case 
where no children exist in updateAssignments
    
    ## What changes were proposed in this pull request?
    
    Fix a bug in which BisectingKMeans fails with error:
    java.util.NoSuchElementException: key not found: 166 
            at scala.collection.MapLike$class.default(MapLike.scala:228) 
            at scala.collection.AbstractMap.default(Map.scala:58) 
            at scala.collection.MapLike$class.apply(MapLike.scala:141) 
            at scala.collection.AbstractMap.apply(Map.scala:58) 
            at 
org.apache.spark.mllib.clustering.BisectingKMeans$$anonfun$org$apache$spark$mllib$clustering$BisectingKMeans$$updateAssignments$1$$anonfun$2.apply$mcDJ$sp(BisectingKMeans.scala:338)
            at 
org.apache.spark.mllib.clustering.BisectingKMeans$$anonfun$org$apache$spark$mllib$clustering$BisectingKMeans$$updateAssignments$1$$anonfun$2.apply(BisectingKMeans.scala:337)
            at 
org.apache.spark.mllib.clustering.BisectingKMeans$$anonfun$org$apache$spark$mllib$clustering$BisectingKMeans$$updateAssignments$1$$anonfun$2.apply(BisectingKMeans.scala:337)
            at 
scala.collection.TraversableOnce$$anonfun$minBy$1.apply(TraversableOnce.scala:231)
 
            at 
scala.collection.LinearSeqOptimized$class.foldLeft(LinearSeqOptimized.scala:111)
 
            at scala.collection.immutable.List.foldLeft(List.scala:84) 
            at 
scala.collection.LinearSeqOptimized$class.reduceLeft(LinearSeqOptimized.scala:125)
 
            at scala.collection.immutable.List.reduceLeft(List.scala:84) 
            at 
scala.collection.TraversableOnce$class.minBy(TraversableOnce.scala:231) 
            at 
scala.collection.AbstractTraversable.minBy(Traversable.scala:105) 
            at 
org.apache.spark.mllib.clustering.BisectingKMeans$$anonfun$org$apache$spark$mllib$clustering$BisectingKMeans$$updateAssignments$1.apply(BisectingKMeans.scala:337)
 
            at 
org.apache.spark.mllib.clustering.BisectingKMeans$$anonfun$org$apache$spark$mllib$clustering$BisectingKMeans$$updateAssignments$1.apply(BisectingKMeans.scala:334)
 
            at scala.collection.Iterator$$anon$11.next(Iterator.scala:328) 
            at scala.collection.Iterator$$anon$14.hasNext(Iterator.scala:389) 
    
    ## How was this patch tested?
    
    The dataset was run against the code change to verify that the code works.  
I will try to add unit tests to the code.
    
    (Please explain how this patch was tested. E.g. unit tests, integration 
tests, manual tests)
    (If this patch involves UI changes, please attach a screenshot; otherwise, 
remove this)
    
    Please review http://spark.apache.org/contributing.html before opening a 
pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/imatiach-msft/spark ilmat/fix-kmeans

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/16355.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16355
    
----
commit f77904d3162f3cfddd86d7d54b47eab725e67626
Author: Ilya Matiach <il...@microsoft.com>
Date:   2016-12-20T18:30:24Z

    [SPARK-16473][MLLIB] Fix BisectingKMeans Algorithm failing in edge case 
where no children exist in updateAssignments

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to