Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/16360#discussion_r93350564
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulAggregate.scala
---
@@ -180,11 +181,41 @@ case class StateStoreSaveExec(
// Update and output modified rows from the StateStore.
case Some(Update) =>
+
+ // Note: Update mode can be done with or without a specified
watermark
+ val optionalWatermarkAttribute =
+
keyExpressions.find(_.metadata.contains(EventTimeWatermark.delayKey))
+
+ val optionalPredicate = optionalWatermarkAttribute.map {
watermarkAttribute =>
+ // If we are evicting based on a window, use the end of the
window. Otherwise just
--- End diff --
any reason why you wouldn't want to make this a method? Seems exactly the
same as above under `append` mode
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
