Github user ryan-williams commented on the issue:
https://github.com/apache/spark/pull/16311
@srowen thx, one comment:
> It does indeed require editing all the POMs but it's straightforward.
The other option that I described
[above](https://github.com/apache/spark/pull/16311#issuecomment-267657034) is
to express the "each module needs a spark-tags test-dep" requirement once, in
the spark-parent POM's `<dependencies/>` tag.
@vanzin on that note, I guess I am proximally blocked on this question of
whether to just hard-code a spark-tags dep into every submodule's POM, or try
to factor it out a little more cleanly, albeit with a bit more pom-inheritance
contortions.
I'm also balking at a higher-level at some apparent messiness of the
overall build landscape that this has run into:
- we have submodule-specific tags that have been module-sharded by their
tag-ness instead of by their submodule-relevance, which are used to manually
control whether to run certain tests in certain situations (as opposed to, say,
the build system understanding when they'd need to be run based on changes to
things they depend on).
- apparently the way they are used is broken by this PR, but the
already-3hr build does not know about that, and passes.
So I'm not really sure what the best way to proceed is; I could almost
squint and say the requirement for all possible tags to be on the classpath
when running unrelated modules' tests is a problem with Scalatest, or
Scalatest's interactions with Spark's submodule-landscape, or something else
altogether.
Anyway we can keep discussing or someone is welcome to fork this PR
themselves and push through some seemingly-least-evil solution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
