Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16377#discussion_r93535456
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/DecisionTreeMetadata.scala
---
@@ -113,6 +113,10 @@ private[spark] object DecisionTreeMetadata extends
Logging {
throw new IllegalArgumentException(s"DecisionTree requires size of
input RDD > 0, " +
s"but was given by empty one.")
}
+ if (numFeatures == 0) {
--- End diff --
would having two different error messages for the two cases be preferred?
It seems that we want to communicate to the user that either:
1.) the input RDD is empty, or
2.) the input is not empty but the features vector is empty
I will take the second suggestion and update with the require
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
