Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16322#discussion_r93554618
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamTest.scala ---
    @@ -228,7 +228,8 @@ trait StreamTest extends QueryTest with 
SharedSQLContext with Timeouts {
        */
       def testStream(
           _stream: Dataset[_],
    -      outputMode: OutputMode = OutputMode.Append)(actions: StreamAction*): 
Unit = {
    +      outputMode: OutputMode = OutputMode.Append,
    +      ignoreThreadDeathCause: Boolean = false)(actions: StreamAction*): 
Unit = {
    --- End diff --
    
    This `ignore` field is really hard to understand as a user of this 
function. And adding a field to just for one test does not make sense. Rather 
make an action ExpectStreamThreadException. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to