Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/16380#discussion_r93566199
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/TransportChannelHandler.java
---
@@ -88,29 +88,29 @@ public void channelActive(ChannelHandlerContext ctx)
throws Exception {
try {
requestHandler.channelActive();
} catch (RuntimeException e) {
- logger.error("Exception from request handler while registering
channel", e);
+ logger.error("Exception from request handler while channel is
active", e);
}
try {
responseHandler.channelActive();
} catch (RuntimeException e) {
- logger.error("Exception from response handler while registering
channel", e);
+ logger.error("Exception from response handler while channel is
active", e);
}
- super.channelRegistered(ctx);
+ super.channelActive(ctx);
}
--- End diff --
Good catch !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
