Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r93713654
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -78,11 +108,21 @@ case class CurrentTimestamp() extends LeafExpression
with CodegenFallback {
*
* There is no code generation since this expression should be replaced
with a literal.
*/
-case class CurrentBatchTimestamp(timestampMs: Long, dataType: DataType)
- extends LeafExpression with Nondeterministic with CodegenFallback {
+case class CurrentBatchTimestamp(timestampMs: Long, dataType: DataType,
timeZoneId: String = null)
+ extends LeafExpression with TimeZoneAwareExpression with
Nondeterministic with CodegenFallback {
+
+ def this(timestampMs: Long, dataType: DataType) = this(timestampMs,
dataType, null)
override def nullable: Boolean = false
+ override def timeZoneResolved: Boolean = dataType != DateType ||
super.timeZoneResolved
--- End diff --
Doesn't a timestamp also need a timezone?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
