Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r93723027
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -635,4 +638,13 @@ class DataFrameReaderWriterSuite extends QueryTest
with SharedSQLContext with Be
checkAnswer(spark.table("t"), Row(1, "a") :: Row(2, "b") :: Nil)
}
}
+
+ test("use saveAsTable to append to a data source table implementing
CreatableRelationProvider") {
+ withTable("t") {
+ val provider = "org.apache.spark.sql.test.DefaultSource"
--- End diff --
The data source is defined in this file:
https://github.com/apache/spark/pull/15996/files#diff-b9ddfbc9be8d83ecf100b3b8ff9610b9R48
I think it's easy to tell that it extends `CreatableRelationProvider` but
not return a `InsertableRelation`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]