Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13909#discussion_r93792263
  
    --- Diff: 
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
 ---
    @@ -287,6 +287,57 @@ public UnsafeMapData getMap(int ordinal) {
         return map;
       }
     
    +  @Override
    +  public void update(int ordinal, Object value) { throw new 
UnsupportedOperationException(); }
    +
    +  public void setNullAt(int ordinal) {
    +    assertIndexIsValid(ordinal);
    +    BitSetMethods.set(baseObject, baseOffset + 8, ordinal);
    +
    +    /* we assume the corrresponding column was already 0 */
    --- End diff --
    
    `...was already 0 or will be set to 0 later by the caller side`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to