Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15664#discussion_r93846787
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -112,7 +112,25 @@ object JdbcUtils extends Logging {
*/
def insertStatement(conn: Connection, table: String, rddSchema:
StructType, dialect: JdbcDialect)
: PreparedStatement = {
- val columns = rddSchema.fields.map(x =>
dialect.quoteIdentifier(x.name)).mkString(",")
+ // Use database column names instead of RDD schema column names
+ val tableSchemaQuery =
conn.prepareStatement(dialect.getSchemaQuery(table))
+ var columns: String = ""
+ try {
+ val tableSchema = getSchema(tableSchemaQuery.executeQuery(), dialect)
+ val nameMap = tableSchema.fields.map(f => f.name -> f.name).toMap
+ val lowercaseNameMap = tableSchema.fields.map(f =>
f.name.toLowerCase -> f.name).toMap
+ columns = rddSchema.fields.map { x =>
+ if (nameMap.isDefinedAt(x.name)) {
+ dialect.quoteIdentifier(x.name)
+ } else if (lowercaseNameMap.isDefinedAt(x.name.toLowerCase)) {
+ dialect.quoteIdentifier(lowercaseNameMap(x.name.toLowerCase))
+ } else {
+ throw new SQLException(s"""Column "${x.name}" not found""")
+ }
--- End diff --
The name resolution should be still controlled by
`spark.sql.caseSensitive`, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
