Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16402#discussion_r93880623
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -92,10 +92,10 @@ class CodegenContext {
* This is for minor objects not to store the object into field but
refer it from the references
* field at the time of use because number of fields in class is limited
so we should reduce it.
*/
- def addReferenceObj(obj: Any): String = {
+ def addMinorReferenceObj(obj: Any, className: String = null): String = {
--- End diff --
To be consistent with the above comments, how about `addReferenceMinorObj`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
