Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16409#discussion_r93898675
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala ---
@@ -44,9 +44,6 @@ class JDBCWriteSuite extends SharedSQLContext with
BeforeAndAfter {
val testH2Dialect = new JdbcDialect {
override def canHandle(url: String) : Boolean =
url.startsWith("jdbc:h2")
- override def getCatalystType(
--- End diff --
If we get rid of this, how can it pass the test case ["Remap types via
JdbcDialects"](https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala#L619).
At least, it failed in my local environement.
This overwrite was intentionally introduced for testing JdbcDialect. See
the PR: https://github.com/apache/spark/pull/5498
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
