Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15664#discussion_r94007008
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala
---
@@ -60,23 +60,27 @@ class JdbcRelationProvider extends
CreatableRelationProvider
val conn = JdbcUtils.createConnectionFactory(jdbcOptions)()
try {
- val tableExists = JdbcUtils.tableExists(conn, url, table)
+ val tableSchema = JdbcUtils.getSchema(conn, url, table)
+ val tableExists = tableSchema.isDefined
+ val caseSensitive = sqlContext.conf.caseSensitiveAnalysis
if (tableExists) {
mode match {
case SaveMode.Overwrite =>
- if (isTruncate && isCascadingTruncateTable(url) ==
Some(false)) {
+ val savingSchema = if (isTruncate &&
isCascadingTruncateTable(url) == Some(false)) {
// In this case, we should truncate table and then load.
truncateTable(conn, table)
- saveTable(df, url, table, jdbcOptions)
+ JdbcUtils.getSavingSchema(df.schema, tableSchema.get,
caseSensitive)
} else {
// Otherwise, do not truncate the table, instead drop and
recreate it
dropTable(conn, table)
createTable(df.schema, url, table, createTableOptions, conn)
- saveTable(df, url, table, jdbcOptions)
+ df.schema
}
+ saveTable(df, url, table, savingSchema, jdbcOptions)
--- End diff --
That could be. But, to do that, `JdbcUtil.saveTable` need to understand
`SaveMode`, too. Is it okay?
Currently, `JdbcUtil` only provides somewhat primitive APIs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
