Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/16427#discussion_r94093910
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2585,9 +2586,12 @@ class Dataset[T] private[sql](
* Creates a local temporary view using the given name. The lifetime of
this
* temporary view is tied to the [[SparkSession]] that was used to
create this Dataset.
*
+ * @throws AnalysisException if the view name is invalid
+ *
* @group basic
* @since 2.0.0
*/
+ @throws[AnalysisException]
--- End diff --
Then, just document and don't add this annotation?
Actually, I added this because I indeed felt uncomfortable with `public`
API raises undocumented exception.
In fact, both `Table already exists` and `Invalid table name` are equally
`AnalysisException`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
