Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16371#discussion_r94104643
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/collect.scala
---
@@ -29,12 +30,10 @@ import org.apache.spark.sql.types._
/**
* The Collect aggregate function collects all seen expression values into
a list of values.
*
- * The operator is bound to the slower sort based aggregation path because
the number of
- * elements (and their memory usage) can not be determined in advance.
This also means that the
- * collected elements are stored on heap, and that too many elements can
cause GC pauses and
- * eventually Out of Memory Errors.
+ * We have to store all the collected elements in memory, and that too
many elements can cause GC
+ * paused and eventually OutOfMemory Errors.
*/
-abstract class Collect extends ImperativeAggregate {
+abstract class Collect[T] extends TypedImperativeAggregate[T] {
--- End diff --
yeah, that's good idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
