Github user mpjlu commented on the issue:

    https://github.com/apache/spark/pull/15212
  
    hi @jkbradley @yanboliang , I have created a follow up PR for this PR. 
https://github.com/apache/spark/pull/16434
    I have not added FDR test in ML Suite. The main reason is the current data 
set is not a good case for FDR test (you can only select 0 feature or all 3 
features by FDR).  Do you think I should write a new data set like in MLLIB to 
test FDR in ML.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to